-
Notifications
You must be signed in to change notification settings - Fork 31.2k
Visual Attention Network (VAN) #16027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
39a9447 to
69f4de1
Compare
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this model!
| ("vit_mae", "ViTFeatureExtractor"), | ||
| ("segformer", "SegformerFeatureExtractor"), | ||
| ("convnext", "ConvNextFeatureExtractor"), | ||
| ("van", "ConvNextFeatureExtractor"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-using this for all models? ;)
You're sure it expects the same transforms at evaluation time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was trained on imagenet
| logger = logging.get_logger(__name__) | ||
|
|
||
| VAN_PRETRAINED_CONFIG_ARCHIVE_MAP = { | ||
| "van-base": "https://huggingface.co/zuppif/van-base/blob/main/config.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated
| src/transformers/models/convnext/modeling_convnext.py | ||
| src/transformers/models/poolformer/modeling_poolformer.py | ||
| src/transformers/models/vit_mae/modeling_vit_mae.py | ||
| src/transformers/models/van/modeling_van.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Did you checks the tests pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is done in the CI, isn't it?
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
49a76b0 to
41bcfef
Compare
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
|
Thanks for the reviews. I've resolved all the comments that can be resolved and asked the authors if we can create an organization for them in the hub. |
What does this PR do?
This PR adds Visual Attention Network.
Currently, the model can be used as follows
TODO