Improve Swin for VisionEncoderDecoder #16070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Mar 11, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this!
added 2 commits
March 14, 2022 20:58
NielsRogge
force-pushed
the
add_swin_test
branch
from
3a3d47c to
152d491
Compare
FrancescoSaverioZuppichini
approved these changes
Mar 15, 2022
Contributor
FrancescoSaverioZuppichini
left a comment
FrancescoSaverioZuppichini
left a comment
There was a problem hiding this comment.
Thanks :) LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves support for the Swin Transformer with the
VisionEncoderDecoderModelframework.Thanks to @FrancescoSaverioZuppichini we now have general formulas to compute the sequence length and hidden size of the last hidden state of Swin Transformer.