Skip to content

Conversation

@osanseviero
Copy link
Contributor

@osanseviero osanseviero commented Mar 11, 2022

What does this PR do?

This PR fixes 3 issues with zero-shot-image-classification

  • It does not pick a default model, although there is one. This leads to weird error message
pipe = pipeline("zero-shot-image-classification")
>> ValueError: The task defaults can't be correctly selected. You probably meant "translation_XX_to_YY"

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil @sgugger

@osanseviero osanseviero requested review from Narsil and sgugger March 11, 2022 16:35
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osanseviero osanseviero merged commit 802984a into master Mar 14, 2022
@osanseviero osanseviero deleted the fix-zero-shot-docs branch March 14, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants