Skip to content

Conversation

@vumichien
Copy link
Contributor

@vumichien vumichien commented Mar 13, 2022

What does this PR do?

As part of #16051 this PR changes the unpacking of the inputs of TF mobilebert to use the decorator instead.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @gante

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this <3 Two things:

  1. Tests are failing due to formatting -- make fixup should fix it
  2. Can you confirm that RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py runs?

@vumichien
Copy link
Contributor Author

vumichien commented Mar 14, 2022

@gante I have run the test and all pass. But when I run make fixup in my windows laptop it throws the error -n was unexpected at this time. make: *** [Makefile:10: modified_only_fixup] Error 255 Do you know how to fix it?

@gante
Copy link
Contributor

gante commented Mar 14, 2022

@gante I have run the test and all pass. But when I run make fixup in my windows laptop it throws the error -n was unexpected at this time. make: *** [Makefile:10: modified_only_fixup] Error 255 Do you know how to fix it?

Check our guide here :)

Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge as soon as CI turns green 👍

@vumichien
Copy link
Contributor Author

Thank you :D

@gante gante merged commit e3645fd into huggingface:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants