Better input variable naming for OpenAI (TF) #16129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Mar 14, 2022
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Thank you for this one as well :D Same deal as in the other PR, as soon as I get a positive answer for the two points below:
- confirm that the tests pass (
RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py) - address my other comment
| output_type=TFBaseModelOutput, | ||
| config_class=_CONFIG_FOR_DOC, | ||
| ) | ||
| @unpack_inputs |
Contributor
There was a problem hiding this comment.
Same as in the other PR -- can I ask you to move it so as to be the top decorator? :) (there are other instances in this file)
Contributor
Author
There was a problem hiding this comment.
Yes, thank you for catching this. Done in e6da312
Contributor
|
I've also made the same edit on the PR description :) |
Contributor
Author
|
@gante Made changes as you suggested and I'm confirming that the tests pass for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the @unpack_inputs decorator instead of input_processing for OpenAI (TF). See #16051
Tagging @Rocketknight1 for review!
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.