clearer model variable naming: Tapas #16145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Mar 15, 2022
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Perfect 🔥 Thank you so much for your contribution!
Can you confirm that you've run the tests (RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py)? Will merge as soon as I have your confirmation.
Contributor
Author
============================================================================= test session starts =============================================================================
platform darwin -- Python 3.8.9, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /Users/kamal.raj/.virtualenvs/transformers/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/kamal.raj/Documents/GitHub/transformers/.hypothesis/examples')
rootdir: /Users/kamal.raj/Documents/GitHub/transformers, configfile: setup.cfg
plugins: xdist-2.4.0, timeout-2.0.1, dash-2.0.0, hypothesis-6.31.3, forked-1.3.0, typeguard-2.13.2
collected 49 items
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_attention_outputs <- tests/test_modeling_tf_common.py PASSED [ 2%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_compile_tf_model <- tests/test_modeling_tf_common.py PASSED [ 4%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_config PASSED [ 6%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_determinism <- tests/test_modeling_tf_common.py PASSED [ 8%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_for_masked_lm PASSED [ 10%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_for_question_answering PASSED [ 12%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_for_sequence_classification PASSED [ 14%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_forward_signature <- tests/test_modeling_tf_common.py PASSED [ 16%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_generate_with_headmasking <- tests/test_modeling_tf_common.py PASSED [ 18%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_headmasking <- tests/test_modeling_tf_common.py PASSED [ 20%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_hidden_states_output <- tests/test_modeling_tf_common.py PASSED [ 22%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_initialization <- tests/test_modeling_tf_common.py PASSED [ 24%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_inputs_embeds <- tests/test_modeling_tf_common.py PASSED [ 26%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_keras_save_load <- tests/test_modeling_tf_common.py PASSED [ 28%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_keyword_and_dict_args <- tests/test_modeling_tf_common.py PASSED [ 30%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_lm_head_model_beam_search_generate_dict_outputs <- tests/test_modeling_tf_common.py PASSED [ 32%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_lm_head_model_no_beam_search_generate_dict_outputs <- tests/test_modeling_tf_common.py PASSED [ 34%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_lm_head_model_random_beam_search_generate <- tests/test_modeling_tf_common.py PASSED [ 36%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_lm_head_model_random_no_beam_search_generate <- tests/test_modeling_tf_common.py PASSED [ 38%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_load_with_mismatched_shapes <- tests/test_modeling_tf_common.py PASSED [ 40%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_loss_computation <- tests/test_modeling_tf_common.py PASSED [ 42%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_model PASSED [ 44%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_model_common_attributes <- tests/test_modeling_tf_common.py PASSED [ 46%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_model_main_input_name <- tests/test_modeling_tf_common.py PASSED [ 48%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_model_outputs_equivalence <- tests/test_modeling_tf_common.py PASSED [ 51%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_numpy_arrays_inputs <- tests/test_modeling_tf_common.py PASSED [ 53%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_onnx_compliancy <- tests/test_modeling_tf_common.py PASSED [ 55%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_onnx_runtime_optimize <- tests/test_modeling_tf_common.py PASSED [ 57%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_pt_tf_model_equivalence <- tests/test_modeling_tf_common.py SKIPPED (test is PT+TF test) [ 59%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_resize_token_embeddings <- tests/test_modeling_tf_common.py PASSED [ 61%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_save_load <- tests/test_modeling_tf_common.py PASSED [ 63%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelTest::test_save_load_config <- tests/test_modeling_tf_common.py PASSED [ 65%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_classification_head PASSED [ 67%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_masked_lm SKIPPED (Model not available yet) [ 69%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_no_head PASSED [ 71%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_question_answering_head_conversational PASSED [ 73%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_question_answering_head_conversational_absolute_embeddings PASSED [ 75%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_question_answering_head_strong_supervision PASSED [ 77%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_inference_question_answering_head_weak_supervision PASSED [ 79%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasModelIntegrationTest::test_training_question_answering_head_weak_supervision PASSED [ 81%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_flatten PASSED [ 83%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_gather PASSED [ 85%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_gather_vectorized PASSED [ 87%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_product_index PASSED [ 89%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_range_index_map PASSED [ 91%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_reduce_max PASSED [ 93%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_reduce_mean PASSED [ 95%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_reduce_sum PASSED [ 97%]
tests/tapas/test_modeling_tf_tapas.py::TFTapasUtilsTest::test_reduce_sum_vectorized PASSED [100%]
============================================================================== warnings summary ===============================================================================
../../../.virtualenvs/transformers/lib/python3.8/site-packages/flatbuffers/compat.py:19
/Users/kamal.raj/.virtualenvs/transformers/lib/python3.8/site-packages/flatbuffers/compat.py:19: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
-- Docs: https://docs.pytest.org/en/stable/warnings.html
============================================================ 47 passed, 2 skipped, 1 warning in 105.84s (0:01:45) ============================================================= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
clearer model variable naming: Tapas
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@gante