Skip to content

Conversation

@omarespejel
Copy link
Contributor

What does this PR do?

This PR applies the framework split performed in PR #16030 to the Spanish version of quicktour.mdx.

@omarespejel omarespejel requested a review from sgugger March 17, 2022 04:39
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
There are a few examples where the syntax is completely changed in your PR. Can you fix them?

@omarespejel
Copy link
Contributor Author

Sorry for those mistakes! My IDE was formatting MD-style files funny.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better, thanks!

@sgugger sgugger merged commit c36b856 into huggingface:master Mar 21, 2022
@omarespejel omarespejel deleted the apply-framework-split-spanish branch March 21, 2022 16:13
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 24, 2022
* Apply framework changes

* Fix italics

* Fix nits

* correct syntax

Co-authored-by: Omar Espejel <espejelomar@Omars-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants