Skip to content

Conversation

@patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Mar 17, 2022

What does this PR do?

Remove jax.ops.index as this method is removed in latest jax release v0.3.2.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 17, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

There seem to be some failing tests still :-)

@patil-suraj
Copy link
Contributor Author

patil-suraj commented Mar 17, 2022

The failing tests are not related to this PR.

@ydshieh
Copy link
Collaborator

ydshieh commented Mar 17, 2022

Hi, I am not very into the detail here, but curious about that if this implies from this version, transformers will only work with the new version of jax?

@patil-suraj
Copy link
Contributor Author

Hi, I am not very into the detail here, but curious about that if this implies from this version, transformers will only work with the new version of jax?

No, the .at syntax is also supported in older jax versions.

@patrickvonplaten
Copy link
Contributor

Feel free to merge if you want @patil-suraj

@patil-suraj patil-suraj merged commit 93d3fd8 into huggingface:master Mar 17, 2022
@patil-suraj patil-suraj deleted the fix-jax-indexing branch March 17, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants