Add type hints for UniSpeech #16399
Merged
Add type hints for UniSpeech #16399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
Hey, this looks good but I'm going to leave a final review until the |
…unispeech_type_hints
Contributor
Author
|
Yeah, I think I will work on it and make a commit right away |
Contributor
Author
|
There are some other models that are dependent on Wave2Vec2, I will modify them asap |
Contributor
Author
|
@Rocketknight1 I think it's good to go now |
Rocketknight1
approved these changes
Mar 29, 2022
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Looks great to me, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type hints for forward methods in user-facing class for UniSpeech as mentioned in #16059
@Rocketknight1