Replace Optional and Union typing with | in some source files #42294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
force-pushed
the
example_union
branch
from
667a945 to
b3b07d8
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
force-pushed
the
example_union
branch
from
b3b07d8 to
a6adae5
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Rocketknight1
approved these changes
Nov 20, 2025
Member
There was a problem hiding this comment.
Changes LGTM! The failing test should be fixed with a rebase now that #42301 is merged
Contributor
Author
|
@Rocketknight1 It's green now. |
Rocketknight1
approved these changes
Nov 24, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yep, changes LGTM now, and I like the modern style a lot more. Thank you!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uses Python 3.10
|for Union and Optional types.