[Feature] Add Ascend NPU accelerator support #1096
Merged
younesbelkada merged 2 commits intohuggingface:mainfrom Dec 15, 2023
ji-huazhong:npu-support
Merged
[Feature] Add Ascend NPU accelerator support #1096younesbelkada merged 2 commits intohuggingface:mainfrom ji-huazhong:npu-support
younesbelkada merged 2 commits intohuggingface:mainfrom
ji-huazhong:npu-support
Conversation
Contributor
Author
|
@younesbelkada @lvwerra I tried using |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Looks great thank you very much for adding the NPU support! can you run the styling checks? make precommit
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@younesbelkada Thanks for your reminder. CI is green:) |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* add npu support * make precommit
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* add npu support * make precommit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since npu already supports Transformer/Accelerate and Peft out of the box, this would be a good addition to run TRL out of the box on npu.
cc @younesbelkada and @lvwerra