Remove CUDA synchronization in mean_token_accuracy #2902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't understand the profiling actually. Where do you get that this line is the bottleneck? |
cyyever
changed the title
Contributor
Author
|
@qgallouedec It is the sixth line in the first picture. It's not a main bottleneck, however, the GPU utility rose a bit after fixing it. |
Member
|
This? |
Member
|
The comparison is not very clear to me tbh, do you have clearer results, like two trainings (one with main, one with your branch) where we can see the speedup in term of steps/sec? |
Contributor
Author
|
@qgallouedec Of course, I will provide a comparison ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mean_token_accuracy computation invokes
item()on token counts, which triggers CUDA to CPU synchronization. That synchronization becomes a minor performance bottleneck in LLM fine-tuning, as indicated by the following profiling snapshot from v0.15.1:That bottleneck has been fixed in this PR by accumulating the correct and total token counts in tensors.
item()calls are delayed untiltrainer.log().The effects of the change are indicated by another profiling that the bottleneck disappears:
Because the metrics are cleared immediately after logging, this change should be safe and backwards-compatible.
Before submitting
Pull Request section?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.