[SFTTrainer] Check correctly for condition#668
Merged
younesbelkada merged 1 commit intomainfrom Sep 6, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
approved these changes
Aug 21, 2023
Member
|
Maybe we can mock in the tests that peft is not installed and test that it still runs? |
Contributor
Author
|
Will be doing it in a follow up PR (to unlock #735) ! |
kushal-tri
pushed a commit
to kushalarora/trl
that referenced
this pull request
Sep 19, 2023
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #667
Fixes #735
if PEFT is not installed SFTTrainer will throw an error when checking
isinstance(model, (PreTrainedModel, PeftModel))asPeftModelis defined nowhere in the script if PEFT is not availablecc @lvwerra