Skip to content

[DPO] fix DPO ref_model=None#703

Merged
younesbelkada merged 3 commits intohuggingface:mainfrom
kashif:dpo-issue
Aug 29, 2023
Merged

[DPO] fix DPO ref_model=None#703
younesbelkada merged 3 commits intohuggingface:mainfrom
kashif:dpo-issue

Conversation

@kashif
Copy link
Copy Markdown
Collaborator

@kashif kashif commented Aug 29, 2023

by @tannonk fixes #699 and #701

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 29, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @kashif !

Comment thread trl/trainer/dpo_trainer.py Outdated
kashif and others added 2 commits August 29, 2023 12:31
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
@younesbelkada younesbelkada merged commit 7fc9709 into huggingface:main Aug 29, 2023
@younesbelkada younesbelkada deleted the dpo-issue branch August 29, 2023 10:57
kushal-tri pushed a commit to kushalarora/trl that referenced this pull request Sep 19, 2023
* fix by @tannonk

* Update trl/trainer/dpo_trainer.py

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>

* add import

---------

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* fix by @tannonk

* Update trl/trainer/dpo_trainer.py

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>

* add import

---------

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
* fix by @tannonk

* Update trl/trainer/dpo_trainer.py

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>

* add import

---------

Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use ref_model=None with DPOTrainer

3 participants