[PPOTrainer] - add comment of zero masking (from second query token)#763
Merged
younesbelkada merged 1 commit intohuggingface:mainfrom Sep 13, 2023
Merged
[PPOTrainer] - add comment of zero masking (from second query token)#763younesbelkada merged 1 commit intohuggingface:mainfrom
younesbelkada merged 1 commit intohuggingface:mainfrom
Conversation
It took a while to understand why zero-masked tokens are one less than the length of query tokens. If I got it correctly, it is because the first logit (and state-value) from the outputs refers to the second token in the query. Hope this comment can be helpful to others who may encounter a similar question in the first-pass reading of the code :)
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Sep 13, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Great, makes sense, thank you!
kushal-tri
pushed a commit
to kushalarora/trl
that referenced
this pull request
Sep 19, 2023
…uggingface#763) It took a while to understand why zero-masked tokens are one less than the length of query tokens. If I got it correctly, it is because the first logit (and state-value) from the outputs refers to the second token in the query. Hope this comment can be helpful to others who may encounter a similar question in the first-pass reading of the code :)
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…uggingface#763) It took a while to understand why zero-masked tokens are one less than the length of query tokens. If I got it correctly, it is because the first logit (and state-value) from the outputs refers to the second token in the query. Hope this comment can be helpful to others who may encounter a similar question in the first-pass reading of the code :)
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
…uggingface#763) It took a while to understand why zero-masked tokens are one less than the length of query tokens. If I got it correctly, it is because the first logit (and state-value) from the outputs refers to the second token in the query. Hope this comment can be helpful to others who may encounter a similar question in the first-pass reading of the code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took a while to understand why zero-masked tokens are one less than the length of query tokens.
If I got it correctly, it is because the first logit (and state-value) from the outputs refers to the second token in the query.
Hope this comment can be helpful to others who may encounter a similar question in the first-pass reading of the code :)