Skip to content

Changed the default value of the log_with argument#792

Merged
younesbelkada merged 1 commit intohuggingface:mainfrom
filippobistaffa:main
Sep 19, 2023
Merged

Changed the default value of the log_with argument#792
younesbelkada merged 1 commit intohuggingface:mainfrom
filippobistaffa:main

Conversation

@filippobistaffa
Copy link
Copy Markdown
Contributor

@filippobistaffa filippobistaffa commented Sep 19, 2023

This change avoids setting report_to="all" (the default behavior in transformers v4), which could lead to unexpected error messages for inexperienced users. Note that the default value of report_to will change anyway to "none" in transformers v5.

Fixes #788

This change avoids setting report_to="all" (the default behavior in
transformers v4), which could lead to unexpected error messages for
inexperienced users. Note that the default value of report_to will
change anyway to "none" in transformers v5.
Copy link
Copy Markdown
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Sep 19, 2023

The documentation is not available anymore as the PR was closed or merged.

@younesbelkada younesbelkada merged commit 5d30cd4 into huggingface:main Sep 19, 2023
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
This change avoids setting report_to="all" (the default behavior in
transformers v4), which could lead to unexpected error messages for
inexperienced users. Note that the default value of report_to will
change anyway to "none" in transformers v5.
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
This change avoids setting report_to="all" (the default behavior in
transformers v4), which could lead to unexpected error messages for
inexperienced users. Note that the default value of report_to will
change anyway to "none" in transformers v5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in SFTTrainer example

3 participants