[DPO] Revert "Add default Optim to DPO example (#759)"#799
Merged
younesbelkada merged 1 commit intomainfrom Sep 20, 2023
Merged
[DPO] Revert "Add default Optim to DPO example (#759)"#799younesbelkada merged 1 commit intomainfrom
DPO] Revert "Add default Optim to DPO example (#759)"#799younesbelkada merged 1 commit intomainfrom
Conversation
This reverts commit d603e7c.
Contributor
Author
|
We should maybe add directly the RMSProp support in transformers |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d603e7c.
Temporarly reverts #759 as the example script seems to fail on main, making it not usable for users, flagged in d603e7c#commitcomment-127787118
Let's revert the PR until we find a better fix
cc @natolambert