Optionally logging reference response#847
Merged
vwxyzjn merged 11 commits intohuggingface:mainfrom Oct 31, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
reviewed
Oct 10, 2023
Member
lvwerra
left a comment
lvwerra
left a comment
There was a problem hiding this comment.
Generally like the idea of adding reference responses. Since this touches a lot of PEFT logic I'll let @younesbelkada make sure it doesn't break anything :)
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Hi @vwxyzjn thanks a lot for iterating! I really like the optional_peft_ctx context manager!
I left a suggestion to use self.accelerator.unwrap_model once and make use of a local variable to pick up the correct ref model. What do you think?
younesbelkada
approved these changes
Oct 31, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Very clean! Thanks very much Costa for your work on this! 🙏
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Optionally logging reference response * log ref rewards as welll * peft logic re-write * fix peft test case * refactor * push changes * test * Apply suggestions from code review Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * quick fix * black --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* Optionally logging reference response * log ref rewards as welll * peft logic re-write * fix peft test case * refactor * push changes * test * Apply suggestions from code review Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * quick fix * black --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows us to log the reference response in wandb as well, which can help us make a direct comparison of the data.
https://wandb.ai/costa-huang/trl/runs/0m8ylgjy
tested it to work with PEFT as well (needed to refactor the logic a bit) see https://wandb.ai/costa-huang/trl/runs/10i8zl27