Skip to content

updating PPOTrainer docstring#897

Merged
vwxyzjn merged 5 commits intohuggingface:mainfrom
lauraaisling:main
Oct 30, 2023
Merged

updating PPOTrainer docstring#897
vwxyzjn merged 5 commits intohuggingface:mainfrom
lauraaisling:main

Conversation

@lauraaisling
Copy link
Copy Markdown
Contributor

adding specific dict structure to tracker_kwargs doc string to enable changing tracker params like wandb experiment name for ease, avoids needing to go deep into accelerate source

… changing tracker params like wandb experiment name for ease, avoids needing to go deep into accelerate source
Copy link
Copy Markdown
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! maybe @vwxyzjn wants to have a quick look too!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@vwxyzjn
Copy link
Copy Markdown
Contributor

vwxyzjn commented Oct 25, 2023

Running into some minor issues at brentyi/tyro#79 but should be resolved soon.

@vwxyzjn
Copy link
Copy Markdown
Contributor

vwxyzjn commented Oct 30, 2023

Now we can be run it with python examples/scripts/ppo.py --ppo_config.tracker_kwargs='{"wandb": {"entity": "vwxyzjn", "name": "haha"}}' --ppo_config.log_with=wandb

image

@vwxyzjn
Copy link
Copy Markdown
Contributor

vwxyzjn commented Oct 30, 2023

Thanks @lomahony!

@vwxyzjn vwxyzjn merged commit 051d5a1 into huggingface:main Oct 30, 2023
@lauraaisling
Copy link
Copy Markdown
Contributor Author

Thanks very much all! The library is excellent and very user-friendly 💯

lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* adding specific dict structure to tracker_kwargs doc string to enable changing tracker params like wandb experiment name for ease, avoids needing to go deep into accelerate source

* push changes

* set default dict

* refactor

* use typing extension

---------

Co-authored-by: Laura O'Mahony <lauraomahony@L-MacBook-Pro.fritz.box>
Co-authored-by: Costa Huang <costa.huang@outlook.com>
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
* adding specific dict structure to tracker_kwargs doc string to enable changing tracker params like wandb experiment name for ease, avoids needing to go deep into accelerate source

* push changes

* set default dict

* refactor

* use typing extension

---------

Co-authored-by: Laura O'Mahony <lauraomahony@L-MacBook-Pro.fritz.box>
Co-authored-by: Costa Huang <costa.huang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants