Adds model kwargs to SFT and DPO trainers#951
Merged
edbeeching merged 5 commits intomainfrom Nov 6, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
LGTM ! Can you just add a simple check for users that pass both a valid model and model_kwargs to make sure we throw an appropriate error telling users that passing model_kwargs with non-str model is not supported? 🙏 Thanks!
Collaborator
Author
|
@younesbelkada , done. Let me know if you have any other comments |
lvwerra
reviewed
Nov 3, 2023
Member
lvwerra
left a comment
lvwerra
left a comment
There was a problem hiding this comment.
Looks generally good to me, just a small nit regarding naming.
younesbelkada
approved these changes
Nov 3, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Looks great thank you for this @edbeeching !
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* adds model kwargs to SFT and DPO trainers * adds checks for model_kwarg passing when model is not str * changed warning to ValueError * renames model_kwargs to model_init_kwargs * corrects argument names in
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* adds model kwargs to SFT and DPO trainers * adds checks for model_kwarg passing when model is not str * changed warning to ValueError * renames model_kwargs to model_init_kwargs * corrects argument names in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will greatly simplify the alignment handbook so it would be great to have it in the next trl release.