fix: dpo trainer ds config#957
Merged
younesbelkada merged 2 commits intohuggingface:mainfrom Nov 6, 2023
Merged
Conversation
ref_model and model shouldn share the same ds config, so we shouldn modify the ds config directly. or else, it will cause sth wrong when init deepspeed engine
younesbelkada
approved these changes
Nov 6, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
This should be good ! Thanks!
Contributor
|
@mengban before merging can you run the styling checks ? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
import sort by isort
Contributor
Author
ok, I have submitted a new commit to solve the problem of import sorting. |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* fix: dpo trainer ds config ref_model and model shouldn share the same ds config, so we shouldn modify the ds config directly. or else, it will cause sth wrong when init deepspeed engine * fix: import sort import sort by isort
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* fix: dpo trainer ds config ref_model and model shouldn share the same ds config, so we shouldn modify the ds config directly. or else, it will cause sth wrong when init deepspeed engine * fix: import sort import sort by isort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref_model and model shouldnt share the same ds config, so we shouldnt modify the ds config directly. or else, it will cause sth wrong when init deepspeed engine