Closed
Conversation
port8080
reviewed
Dec 18, 2024
| type XorbUploadValueType = (MerkleHash, Vec<u8>, Vec<(MerkleHash, usize)>); | ||
| struct NetworkStatCheckPoint { | ||
| n_bytes: u64, | ||
| start: Instant, |
There was a problem hiding this comment.
I found using std::time::SystemTime more useful in sending these over compared to Instant in #121
port8080
reviewed
Dec 18, 2024
| use crate::errors::DataProcessingError::*; | ||
| use crate::errors::*; | ||
|
|
||
| const DEFAULT_NETWORK_STAT_REPORT_INTERVAL_SEC: u32 = 2; // 2 s |
There was a problem hiding this comment.
You probably have this set low for testing, would prefer larger in prod - maybe 100s
port8080
reviewed
Dec 18, 2024
| while let Some(result) = upload_tasks.join_next().await { | ||
| result??; | ||
| let metrics = result??; | ||
| let mut egress_rate = self.egress_stat.lock().await; |
There was a problem hiding this comment.
Try the lock and optimistically report. I think it is completely OK to skip the update_and_report call if there is lock contention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress adding number of retries to the metrics.
Example tracing: