Clean up WP connector#57
Merged
Merged
Conversation
If no one was subscribed to _all_ emails, it wouldn't send emails even if users had subscribed to same-thread emails.
Member
Author
|
@joehoyle can you check I've not done anything dumb here please? :) |
joehoyle
approved these changes
May 29, 2019
| * @param WP_Post $post Post to notify for. | ||
| * @return string Plain text message. | ||
| */ | ||
| protected function get_post_content_as_text( WP_Post $post ) { |
Member
There was a problem hiding this comment.
Why the type hint here, but not below?
Member
Author
There was a problem hiding this comment.
No real reason, just did it on a whim as I was going.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the updates in #56, there's a bunch of stuff that can be done for some cleanup now.