Apply "uniquified" query ID to all blocks which inherit queryId - #28
Merged
Conversation
The function which deduplicated query IDs on a page and passed that unique ID to the post template inside each query was causing other blocks in the query - pagination, query-filters, no posts message - to be mismatched with the posts displayed. This change should fix that issue by setting the same query ID on all blocks inside a query that should inherit the queryID.
Playwright test results
Details
|
joeleenk
approved these changes
Jul 23, 2026
Collaborator
|
Thanks for finding and fixing this @goldenapples & @joeleenk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function which deduplicated query IDs on a page and passed that unique ID to the post template inside each query was causing other blocks in the query - pagination, query-filters, no posts message - to be mismatched with the posts displayed.
This change should fix that issue by setting the same query ID on all blocks inside a query that should inherit the queryID.