Merge latest master into our fork - #3
Open
roborourke wants to merge 167 commits into
Open
Conversation
Tagging version 1.1.1.
…. This will allow plugin developers to whitelist custom pages if they need them to be public while Members is set to private site mode.
…t seems more consistent with the naming scheme. This also fixes #95
…n't redirect when attempting to visit the account page when site is private. Props @turtlepod Fixes #111
…k to allow plugin devs to enable/disable the Content Permissions meta box for certain post types. Fixes #77
…ding a new role and a new capability. Fixes: #107 Props @pedro-mendonca
… a user on the user edit screen when the multiple roles features is active.
…groups. Pulling this from the current `dev` branch.
…'s no separation.
…more easily be unset via a filter.
… sub-pages of the Members Settings admin page. Note that this may change to "admin views" for more flexibility in the future.
…he edit user screen. This is to prevent long lists of roles from taking up too much screen space.
…m does two things at the moment: 1) Allows plugins to register human-readable and translatable capability labels and 2) Allows capabilities to be added to a cap group when registered. However, the system would allow for us to build other things on top of it in the future. This change addresses #61
…riority. Use it to sort cap groups.
…y used to store collections of data. These were all basically rewrites of the same code. The new code introduces a single Registry class and does away with the factory aspect, which was unnecessary for our needs. Some code changes means a minimum of PHP 5.3 is now required. This commit also introduces the `Members` namespace since we're now committed to PHP 5.3+. Suffice it to say, there's some back-compatibility breakage here for any developers who were using various classes directly. This was always frowned upon, especially considering wrapper functions exist for everything. This should not break back-compat for anyone using those wrapper functions. The plugin should also be bumped to 2.0.0-dev from 1.2.0-dev to keep up with semantic versioning.
…e only roles we register are within the `$wp_roles` object. Fixes: #181
…[members_access]` shortcode. These work the same as the `role` and `capability` parameters. Multiple values can passed to a given parameter by separating the values with a comma.
…ff the ThemeHybrid.com server.
…rce compatibility in the private site feature. Props @jorenmartijn Fixes #182
…s 5.3+, but we're prepping for 3.0.0 when we'll have a hard 5.6+ requirement.
|
@roborourke I submitted the original changes in justintadlock#109 and Justin included some changes in edc4c8b but not all:
Provided the data is sanitized/escaped, I think we could switch back to the source repo rather than making the |
Author
|
Sounds good to me, less overhead :)
…On Tue, 11 Dec 2018 at 21:35, Peter Wilson ***@***.***> wrote:
@roborourke <https://github.com/roborourke> I submitted the original
changes in justintadlock#109
<justintadlock#109> and Justin included
some changes in edc4c8b
<edc4c8b>
but not all:
I'm not going to accept this pull request because there's a lot of stuff
I'm seeing that's simply unnecessary. Mostly, this is when something's
already been sanitized or escaped at a different point in the flow. Or,
times where the code is checking against a whitelist of accepted values.
However, I am going to keep this open because there's some useful items in
there that I'd like to use in the next version.
Provided the data is sanitized/escaped, I think we could switch back to
the source repo rather than making the good the enemy of the perfect.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABbeWR2TRfmFV1j_2ZHxVy8QO4PJwpaks5u4CUigaJpZM4ZODjQ>
.
|
…ction. Adds a donation section for funding 3.0.
…inks the user count on the role list table. Fixes: #197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may / may not want to do this! Perhaps we should PR our changes back to Justin. Thoughts @peterwilsoncc ?