[Reputation Oracle] refactor: auth module error handling #2960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Part of #2928
Context behind the change
authmodule.getByCredentialsfromUserServicebecause in fact it did auth check and shouldn't live there; instead introducedcheckPasswordMatchesHashand use it for auth checksControlledErrorwith204status code, so result is expected to be the sameHow has this been tested?
auth/signup; make sure it can create userauth/signupwith same email; make sure it returns duplicated error message and 409 codeauth/siginwith valid password; make sure it returns jwtauth/siginwith invalid password; make sure it returns 400user/exchange-oracle-registrationwith invalid jwt; make sure it returns 401user/exchange-oracle-registrationwith valid jwt; make sure it returns 200Release plan
Simply merge & deploy
Potential risks; What to monitor; Rollback plan
It might be that there is some client implicitly relying on returned error message/code that changed in this PR. To monitor it we can check logs.