Skip to content

Conversation

@mpblocky
Copy link
Contributor

@mpblocky mpblocky commented Jan 10, 2025

HUM-124

@vercel
Copy link

vercel bot commented Jan 10, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky mpblocky changed the title chore: update input masks passing [HUM-124]: chore: update input masks passing Jan 13, 2025
@mpblocky mpblocky marked this pull request as ready for review January 13, 2025 09:10
@mpblocky
Copy link
Contributor Author

@dnechay ready for review

@dnechay dnechay requested review from dnechay and removed request for adrian-oleskiewicz January 13, 2025 10:03
Copy link
Collaborator

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

  • you already have files structure as data-entry/inputs-masks/<file-name>, so no need to have input-masks as part of the file name, it can be just input-masks/percents
  • no need to import mask directly from its file; you can re-export component in input-masks/index.ts and use it later like import { PercentsInputMask } from '@/shared/components/data-entry/input-masks';

@mpblocky
Copy link
Contributor Author

@dnechay I applied the suggestions, seemed on point :)

Copy link
Collaborator

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment, everything else lgtm

@mpblocky
Copy link
Contributor Author

@dnechay fixed!

@dnechay dnechay merged commit 8d21957 into humanprotocol:develop Jan 14, 2025
3 of 7 checks passed
@dnechay dnechay mentioned this pull request Jan 14, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants