-
Notifications
You must be signed in to change notification settings - Fork 43
[HUM-124]: chore: update input masks passing #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-124]: chore: update input masks passing #2985
Conversation
|
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
packages/apps/human-app/frontend/src/shared/components/data-entry/input.tsx
Show resolved
Hide resolved
|
@dnechay ready for review |
dnechay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions:
- you already have files structure as
data-entry/inputs-masks/<file-name>, so no need to haveinput-masksas part of the file name, it can be justinput-masks/percents - no need to import mask directly from its file; you can re-export component in
input-masks/index.tsand use it later likeimport { PercentsInputMask } from '@/shared/components/data-entry/input-masks';
packages/apps/human-app/frontend/src/shared/components/data-entry/input-masks/index.ts
Outdated
Show resolved
Hide resolved
|
@dnechay I applied the suggestions, seemed on point :) |
dnechay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little comment, everything else lgtm
packages/apps/human-app/frontend/src/shared/components/data-entry/input-masks/index.ts
Outdated
Show resolved
Hide resolved
|
@dnechay fixed! |
HUM-124