Hum 98 sign up refactor #3029
Merged
Hum 98 sign up refactor #3029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
packages/apps/human-app/frontend/src/modules/worker/utils/formatted-sign-up-error-message.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@dnechay ready to review |
dnechay
reviewed
Jan 23, 2025
packages/apps/human-app/frontend/src/modules/worker/views/sign/sign-up.page.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/hooks/use-sign-up.tsx
Outdated
Show resolved
Hide resolved
dnechay
reviewed
Jan 23, 2025
packages/apps/human-app/frontend/src/modules/worker/views/sign/sign-up.page.tsx
Outdated
Show resolved
Hide resolved
adrian-oleskiewicz
force-pushed
the
HUM-98-sign-up-refactor
branch
from
a58a73a to
ad03678
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dnechay
reviewed
Jan 28, 2025
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
LGTM overall, one question about index.ts
Contributor
|
@dnechay ready |
dnechay
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
HUM-98
Context behind the change
Sign up page refactor
split code into smaller hooks, utils (SRP)
How has this been tested?
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A