[Job Launcher] [Client] Infinite spinner when create job fails #3230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
KirillKirill
changed the title
dnechay
reviewed
Mar 26, 2025
packages/apps/job-launcher/client/src/components/Jobs/Create/helpers.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/client/src/components/Jobs/Create/FortuneJobRequestForm.tsx
Show resolved
Hide resolved
packages/apps/job-launcher/client/src/components/Jobs/Create/PayJob.tsx
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/client/src/components/Jobs/Create/LaunchJobProgress.tsx
Show resolved
Hide resolved
packages/apps/job-launcher/client/src/components/Jobs/Create/LaunchJobProgress.tsx
Show resolved
Hide resolved
dnechay
reviewed
Mar 26, 2025
packages/apps/job-launcher/client/src/providers/CreateJobPageUIProvider.tsx
Show resolved
Hide resolved
packages/apps/job-launcher/client/src/providers/CreateJobPageUIProvider.tsx
Outdated
Show resolved
Hide resolved
dnechay
previously approved these changes
Mar 27, 2025
dnechay
previously approved these changes
Mar 28, 2025
Dzeranov
previously approved these changes
Mar 28, 2025
dnechay
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Closes #3209
Context behind the change
The spinner being shown regardless of the request's status, no matter whether it's fulfilled or rejected. Instead, let's display an ErrorIcon if the request is failed. Moreover, I've added a button that lets users get back to the form and see what values might be wrong.
Also this pr includes some refactoring
How has this been tested?
tested it locally: go to the job launching form, fill in all the fields and click on Pay Now. you shall see the error icon and 'cancel' button, that takes you back to the second step
2025-03-26.18.27.12.mov
Release plan
regular plan
Potential risks; What to monitor; Rollback plan
not determined yet