Skip to content

Conversation

@zhiltsov-max
Copy link
Collaborator

@zhiltsov-max zhiltsov-max commented Apr 1, 2025

Issue tracking

Context behind the change

Annotation export for an escrow can take huge amount of time, but it's not really necessary as we do validation in CVAT. This PR moves exporting to happen only after successful escrow acceptance.

Messaging:
old:

  1. EO -> job_finished -> RO
  2. RO -> job_completed -> EO, RepO

new:

  1. EO -> job_finished -> RO
  2. RO -> job_completed -> EO
  3. EO -> escrow_recorded -> RO
  4. RO -> job_completed -> RepO
  • Added a new EO -> RO event escrow_recorded, it is sent after successful annotation export
  • EO:
    • Removed annotation export from validation attempt preparations (right before job_finished event)
    • Added annotation export to RO job_completed event handling
    • Added sending of new event escrow_recorded after successful export in RO job_completed event handling
  • RO:
    • Removed annotation merging and uploading from EO job_finished event handling
    • Removed RepO notification from EO job_finished event handling
    • Added new EO escrow_recorded event handling:
      • GT is merged with assignment annotations, uploaded to RO storage
      • RepO is notified with RO job_completed event

As annotation export is a long operation, it's handled in a separate event handling thread.

How has this been tested?

Release plan

Potential risks; What to monitor; Rollback plan

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 3:55pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 3:55pm
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 3:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 3:55pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 3:55pm

@Dzeranov Dzeranov merged commit 6953efe into develop Apr 1, 2025
17 checks passed
@Dzeranov Dzeranov mentioned this pull request Apr 1, 2025
34 tasks
@zhiltsov-max zhiltsov-max deleted the zm/export-after-escrow-success branch April 1, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants