[Reputation Oracle] webhook module refactoring
#3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
21 tasks
- deleted errors - changed module/service/repositories namings
Dzeranov
force-pushed
the
dzeranov/3084-webhook
branch
from
67c2199 to
7944a05
Compare
dnechay
reviewed
Apr 23, 2025
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
LGTM
Some minor comments for cleanup
packages/apps/reputation-oracle/server/src/modules/webhook/webhook-outgoing.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/webhook/webhook-outgoing.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/webhook/webhook-incoming.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/webhook/webhook-incoming.service.spec.ts
Outdated
Show resolved
Hide resolved
dnechay
approved these changes
Apr 24, 2025
flopez7
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Part of #3084
Context behind the change
webhookmodule refactoringHow has this been tested?
Release plan
N/A
Potential risks; What to monitor; Rollback plan
N/A