Skip to content

[Job Launcher] Check USD decimals #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flopez7 merged 1 commit into from
May 22, 2025
Merged

[Job Launcher] Check USD decimals #3362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/apps/job-launcher/server/src/common/validators/token-decimals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from 'class-validator';
import { TOKEN_ADDRESSES } from '../constants/tokens';
import { ChainId } from '@human-protocol/sdk';
import { EscrowFundToken } from '../enums/job';
import { PaymentCurrency } from '../enums/payment';

@ValidatorConstraint({ async: false })
export class IsValidTokenDecimalsConstraint
Expand All @@ -17,12 +17,19 @@ export class IsValidTokenDecimalsConstraint
const [tokenProperty] = args.constraints;
const dto = args.object as Record<string, any>;
const chainId = dto.chainId as ChainId;
const token = dto[tokenProperty] as EscrowFundToken;
const token = dto[tokenProperty] as PaymentCurrency;

if (!chainId || !token) {
return false;
}

// Check if the token is a fiat currency
if (token === PaymentCurrency.USD) {
if (typeof value !== 'number') return false;
const [, decimals] = value.toString().split('.');
return !decimals || decimals.length <= 2;
}

const tokenInfo = TOKEN_ADDRESSES[chainId]?.[token];

if (!tokenInfo) {
Expand All @@ -35,15 +42,20 @@ export class IsValidTokenDecimalsConstraint
return false;
}

const [_, decimals] = value.toString().split('.');
const [, decimals] = value.toString().split('.');
return !decimals || decimals.length <= maxDecimals;
}

defaultMessage(args: ValidationArguments) {
const [tokenProperty] = args.constraints;
const dto = args.object as Record<string, any>;
const chainId = dto.chainId as ChainId;
const token = dto[tokenProperty] as EscrowFundToken;
const token = dto[tokenProperty] as PaymentCurrency;

if (token === PaymentCurrency.USD) {
return `${args.property} must have at most 2 decimal places for USD payments.`;
}

const tokenInfo = TOKEN_ADDRESSES[chainId]?.[token];
const maxDecimals = tokenInfo?.decimals || 'unknown';

Expand Down
Loading