Content after "var" and "return" is not prefixed

[TomasVotruba]

Bug report

Question	Answer
Box version	0.6.1.0
PHP version	7.2.5
Platform with version	Ubuntu

Probably some regexp issue?

Reported here: rectorphp/rector#465 (comment)

# scoper.inc.php

<?php declare(strict_types=1);

require_once __DIR__ . '/vendor/autoload.php';

use Isolated\Symfony\Component\Finder\Finder;

return [
    'finders' => [
        Finder::create()
            ->files()
            ->in(__DIR__ .'/test-me')
    ]
];

With a run:

php php-scoper.phar add-prefix --no-interaction

Turns this:

<?php

$tagHandlerMappings = [
    'param' => '\phpDocumentor\Reflection\DocBlock\Tags\Param',
    'return' => '\phpDocumentor\Reflection\DocBlock\Tags\Return_',
    'var' => '\phpDocumentor\Reflection\DocBlock\Tags\Var_',
];

to

<?php

namespace _PhpScoper5b0c2a3e20ef8;

$tagHandlerMappings = [
    'param' => '_PhpScoper5b0c2a3e20ef8\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Param',
    'return' => '\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Return_',
    'var' => '\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Var_'
];

Expected Prefixed

<?php

namespace _PhpScoper5b0c2a3e20ef8;

$tagHandlerMappings = [
    'param' => '_PhpScoper5b0c2a3e20ef8\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Param',
-    'return' => '\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Return_',
+    'return' => '_PhpScoper5b0c2a3e20ef8\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Return_',
-    'var' => '\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Var_'
+    'var' => '_PhpScoper5b0c2a3e20ef8\\phpDocumentor\\Reflection\\DocBlock\\Tags\\Var_'
];

[TomasVotruba]

Now I see, that it might be related to "_" in the of the string.

Return_, Var_ vs. Param

Confirmed

 <?php
 
+namespace _PhpScoper5b0d2284c2735;

 $tagHandlerMappings = [
     'SomeNamespace\\SomeClass_',
-    'SomeNamespace\\SomeClass',
+    '_PhpScoper5b0d2284c2735\\SomeNamespace\\SomeClass'
 ];

My Tip

php-scoper/src/PhpParser/NodeVisitor/StringScalarPrefixer.php

Line 75 in b0239f0

|| 1 !== preg_match('/^\\\\*(?:\p{L}+\\\\+)++\p{L}+$/u', $node->value)

[theofidry]

Meh indeed, looks like I assumed wrong when doing that classname regex

[TomasVotruba]

That happens, it very rare case after all. I think I make similar assumptions in my code too