Legalize A5 PIPE_V barriers before VPTO emission#916
Merged
zhangstevenunity merged 1 commit intoJul 9, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds checks to prevent unsupported A5 PIPE_V barriers from reaching the VPTO LLVM lowering stage, and schedules the LoweringSyncToPipe pass in the emission pipeline to legalize sync constructs. The reviewer suggested using assert or llvm_unreachable instead of op.emitError if the condition represents an invariant violation, or removing the "internal error" prefix if it is a user-facing error.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+8644
to
+8649
| if (isTargetArchA5(op.getOperation()) && | ||
| op.getPipe().getPipe() == PIPE::PIPE_V) { | ||
| op.emitError("internal error: A5 PIPE_V barrier should be erased before " | ||
| "VPTO LLVM lowering"); | ||
| return failure(); | ||
| } |
Contributor
There was a problem hiding this comment.
In LLVM/MLIR, if a condition represents an invariant violation (i.e., an internal compiler error that should never be reached in a correct pipeline), it is more idiomatic to use assert or llvm_unreachable rather than op.emitError and returning failure(). This ensures that debug builds fail fast with a stack trace, making it much easier to debug.\n\nIf this condition can actually be triggered by invalid user input (e.g., if a user-provided program contains an unsupported barrier that cannot be legalized/erased), then op.emitError is appropriate, but the error message should be user-friendly and not prefixed with "internal error:".\n\nCould you clarify if this is a compiler invariant or a user-facing error, and update the handling accordingly?
assert(!(isTargetArchA5(op.getOperation()) &&\n op.getPipe().getPipe() == PIPE::PIPE_V) &&\n "A5 PIPE_V barrier should be erased before VPTO LLVM lowering");
Comment on lines
+8588
to
+8593
| if (isTargetArchA5(op.getOperation()) && | ||
| op.getPipe().getPipe() == PIPE::PIPE_V) { | ||
| op.emitError("internal error: A5 PIPE_V barrier should be erased before " | ||
| "VPTO LLVM lowering"); | ||
| return failure(); | ||
| } |
Contributor
There was a problem hiding this comment.
In LLVM/MLIR, if a condition represents an invariant violation (i.e., an internal compiler error that should never be reached in a correct pipeline), it is more idiomatic to use assert or llvm_unreachable rather than op.emitError and returning failure(). This ensures that debug builds fail fast with a stack trace, making it much easier to debug.\n\nIf this condition can actually be triggered by invalid user input (e.g., if a user-provided program contains an unsupported barrier that cannot be legalized/erased), then op.emitError is appropriate, but the error message should be user-friendly and not prefixed with "internal error:".\n\nCould you clarify if this is a compiler invariant or a user-facing error, and update the handling accordingly?
assert(!(isTargetArchA5(op.getOperation()) &&\n op.getPipe().getPipe() == PIPE::PIPE_V) &&\n "A5 PIPE_V barrier should be erased before VPTO LLVM lowering");
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings，因为 review 过程提前失败。 Log Tail |
mouliangyu
approved these changes
Jul 9, 2026
A5 板测失败
日志尾部 |
A3 板测失败
失败用例
|
A3 板测失败详情：PR #916out_proj_residual
down_proj_residual
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.