Skip to content

docs(test): fix stale TensorDump comment to ArgsDump - #1387

Merged
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
ChaoZheng109:fix/args-dump-comment-rename
Jul 17, 2026
Merged

docs(test): fix stale TensorDump comment to ArgsDump#1387
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
ChaoZheng109:fix/args-dump-comment-rename

Conversation

@ChaoZheng109

Copy link
Copy Markdown
Collaborator

What

The dump-tensor DFX subsystem was renamed to dump-args in a prior PR — the collector is ArgsDumpCollector and its subsystem-name string is "ArgsDump" (src/common/platform/include/host/args_dump_collector.h:196), the generated manifest is args_dump/args_dump.json, and all enums/APIs are ArgsDump* / dump_args_*.

One test header comment in tests/ut/cpp/common/test_profiler_base.cpp still referred to the old TensorDump name. This aligns it with the actual subsystem name.

Why

Purely cosmetic — it was the last remaining TensorDump identifier in the tree. No code behavior changes. (The only other tensor_dump string left is an intentional negative-assertion guard in test_args_dump.py verifying the legacy tensor_dump.json is not emitted.)

🤖 Generated with Claude Code

The dump-tensor subsystem was renamed to dump-args (subsystem name
string is "ArgsDump", collector is ArgsDumpCollector). This test
header comment still referred to the old TensorDump name; align it
with the actual subsystem.
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ea55a8c-522b-49c6-99e1-005b3c8344f8

📥 Commits

Reviewing files that changed from the base of the PR and between 172aec1 and 79404d3.

📒 Files selected for processing (1)
  • tests/ut/cpp/common/test_profiler_base.cpp

📝 Walkthrough

Walkthrough

Updated a profiler test documentation comment to replace the TensorDump subsystem reference with ArgsDump; no code logic or test behavior changed.

Changes

Profiler documentation update

Layer / File(s) Summary
Correct profiler subsystem reference
tests/ut/cpp/common/test_profiler_base.cpp
The explanatory comment now names ArgsDump instead of TensorDump.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit with a doc-comment cheer,
ArgsDump now hops clearly here.
No code was changed, no tests were bent,
Just one old name was neatly spent.
Nibble, review, and onward we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the only change: updating a stale TensorDump comment to ArgsDump.
Description check ✅ Passed The description matches the changeset and clearly explains the cosmetic comment update and its context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a comment in the test_profiler_base.cpp file to replace 'TensorDump' with 'ArgsDump' in the description of scheduler-fed subsystems. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ChaoZheng109
ChaoZheng109 merged commit 6e910df into hw-native-sys:main Jul 17, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant