docs(test): fix stale TensorDump comment to ArgsDump - #1387
Conversation
The dump-tensor subsystem was renamed to dump-args (subsystem name string is "ArgsDump", collector is ArgsDumpCollector). This test header comment still referred to the old TensorDump name; align it with the actual subsystem.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated a profiler test documentation comment to replace the ChangesProfiler documentation update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates a comment in the test_profiler_base.cpp file to replace 'TensorDump' with 'ArgsDump' in the description of scheduler-fed subsystems. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
What
The dump-tensor DFX subsystem was renamed to dump-args in a prior PR — the collector is
ArgsDumpCollectorand its subsystem-name string is"ArgsDump"(src/common/platform/include/host/args_dump_collector.h:196), the generated manifest isargs_dump/args_dump.json, and all enums/APIs areArgsDump*/dump_args_*.One test header comment in
tests/ut/cpp/common/test_profiler_base.cppstill referred to the oldTensorDumpname. This aligns it with the actual subsystem name.Why
Purely cosmetic — it was the last remaining
TensorDumpidentifier in the tree. No code behavior changes. (The only othertensor_dumpstring left is an intentional negative-assertion guard intest_args_dump.pyverifying the legacytensor_dump.jsonis not emitted.)🤖 Generated with Claude Code