CI: deduplicate reusable CI workflows - #1640
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesCI Change Detection
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/rules/ci-change-detection.md:
- Around line 185-192: Update the declared-output extraction in the workflow
comparison section to limit parsing to the outputs block of _detect-changes.yml,
excluding workflow_call inputs such as repository and ref. Use the existing
awk-based approach or equivalent block-scoped parsing, while preserving the
current normalization and sorting behavior.
In @.github/workflows/_detect-changes.yml:
- Around line 75-80: Update the “Checkout target ref” step to avoid persisting
checkout credentials on the shared self-hosted runner. Confirm whether the
repository is public; for public repositories disable persisted credentials,
while private repositories should use an explicit access token in the base-fetch
URL rather than relying on checkout’s persisted credential. Preserve the
existing repository and ref selection.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 43e917e7-56e8-4aa4-8e64-47273d14738c
📒 Files selected for processing (5)
.claude/rules/ci-change-detection.md.github/workflows/_detect-changes.yml.github/workflows/ci-self-cpu.yml.github/workflows/ci.ymldocs/ci.md
6723523 to
715ef66
Compare
|
/fix-pr |
|
/github-pr |
7b2e1a2 to
891be54
Compare
Extract duplicated CI job bodies from ci.yml and ci-self-cpu.yml into reusable workflows and composite actions. Keep the caller workflows focused on triggers, topology, gates, runner labels, setup variants, and PR/fork checkout inputs while preserving /run-cpu compatibility and the existing test coverage shape. Validation: git diff --check; YAML parse for workflows/actions; actionlint with self-hosted runner labels; full GitHub CI passed before history cleanup.
891be54 to
2857055
Compare
Summary
.github/workflows/ci.ymland.github/workflows/ci-self-cpu.yml:_detect-changes.yml_pre-commit.yml_ut-no-hardware.yml_packaging.yml_profiling-flags-smoke.yml_st-sim.yml_ut-npu.yml_st-npu.ymlci.ymlandci-self-cpu.ymlto topology callers: triggers,needs, gateif:expressions, matrices, runner labels, setup variants, and PR/fork checkout inputs..github/actions/./run-cpucompatibility:ci-self-cpu.ymlstill supportsworkflow_callandworkflow_dispatch, still acceptsrepository/ref, and still runs the emergency lane on[self-hosted, cpu]plus NPU pools.NON_CODE.Behavior notes
repository@refcheckout path for fork PRs and manual dispatch.needsshape: main CI gated jobs still need bothdetect-changesandpre-commit; CPU lane jobs still only needdetect-changes.Closes #1639
Validation
git diff --check.github/workflows/*.ymland.github/actions/*/action.ymlactionlint -config-file <self-hosted labels config> .github/workflows/*.yml_detect-changes.ymldeclarations andci.yml/ci-self-cpu.ymlconsumers