CI: simplify onboard scene workflows - #1682
Open
luohuan19 wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe A2A3 CI workflows remove the ChangesA2A3 SDMA CI workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luohuan19
force-pushed
the
ci/drop-legacy-sdma-mode
branch
from
August 4, 2026 11:04
0717c89 to
0bdc20a
Compare
Remove the legacy path-based a2a3 SDMA mode and use the marker-based split everywhere. Drop the redundant graphviz warning step and move onboard NPU DFX smokes into dedicated reusable workflows so the base onboard scene workflow has no skip-only DFX toggle.
luohuan19
force-pushed
the
ci/drop-legacy-sdma-mode
branch
from
August 4, 2026 11:12
0bdc20a to
fa0e7cb
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relation to #1639
#1639's main dedupe is already present on
main:ci.ymlandci-self-cpu.ymlshare the canonical_detect-changes.yml, common job bodies are reusableworkflow_callworkflows, and the pip cache / venv scaffolding lives in composite actions.This PR finishes the remaining cleanup from that direction by removing the legacy a2a3 SDMA path mode, the redundant graphviz warning step, and the onboard NPU DFX toggle that made CI Self CPU carry skip-only DFX steps.
Checkout intentionally remains inline as
actions/checkout@v5inside the reusable workflows. A local composite action cannot safely wrap the first checkout step because local actions are loaded from the workspace after checkout has already happened. For the same reason this PR does not add a policy check that bans inline checkout usage.No new structural guard check is added here. The high-risk duplication has been removed structurally; adding a string-scan policy check would expand this cleanup PR and create another maintenance point for normal workflow renames or job reshaping.
Validation
git diff --checkactionlintv1.7.12 on touched workflow filesactionlintonly reports pre-existing custom self-hosted label warnings inci-self-cpu-button.ymlandci-self-cpu-report.yml