Skip to content

CI: drop the redundant concurrency group from the pod job - #1722

Merged
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
luohuan19:support/remove-st-pod-concurrency-group
Aug 6, 2026
Merged

CI: drop the redundant concurrency group from the pod job#1722
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
luohuan19:support/remove-st-pod-concurrency-group

Conversation

@luohuan19

Copy link
Copy Markdown
Contributor

Summary

  • Remove the concurrency group from the st-pod-onboard job in _st-pod.yml, along with the comment that only existed to explain it.

The group existed to stop two runs from sharing the peer machine's devices and its POD_L3_DAEMON_PORT, since a runner claim only covers the machine the job lands on and the peer is driven over ssh. That contention cannot actually occur: the sole caller passes ["self-hosted","Linux","ARM64","a2a3pod"], the a2a3pod label resolves to a single self-hosted runner, and a self-hosted runner executes one job at a time. The group therefore serialized nothing the runner claim did not already serialize, while making runs from unrelated PRs queue behind each other.

Testing

  • pre-commit run --files .github/workflows/_st-pod.yml — all hooks pass (check yaml included)
  • Simulation tests — not applicable (workflow-only change)
  • Hardware tests — not applicable

Note

This is only safe while a2a3pod maps to one runner. If a second pod pair is ever added under the same label, the guard has to come back.

The a2a3pod label resolves to a single self-hosted runner, and a
self-hosted runner executes one job at a time, so two runs of
st-pod-onboard cannot overlap and cannot share the peer machine's
devices or its POD_L3_DAEMON_PORT. The group serialized nothing the
runner claim did not already serialize.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9954e603-5b29-4ed3-8a58-dba846022dd1

📥 Commits

Reviewing files that changed from the base of the PR and between 178c7cb and 443a99e.

📒 Files selected for processing (1)
  • .github/workflows/_st-pod.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/_st-pod.yml

📝 Walkthrough

Walkthrough

The pod workflow no longer uses a concurrency group or non-canceling concurrency setting. Runs for the same platform can execute concurrently.

Changes

Cohort / File(s) Summary
Pod workflow concurrency
.github/workflows/_st-pod.yml
Removes the concurrency configuration from the pod job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit with a workflow tune,
Runs now hop beneath the moon.
No concurrency gate in sight,
Pod jobs leap in parallel flight.
Carrot-certified, neat and bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes removal of the redundant concurrency group from the pod job.
Description check ✅ Passed The description accurately explains the workflow change, its rationale, testing, and the condition for restoring the guard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChaoZheng109
ChaoZheng109 merged commit bba86fd into hw-native-sys:main Aug 6, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants