Skip to content

ci: replaced workflow triggers. #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwakabh merged 1 commit into from
Apr 17, 2025
Merged

ci: replaced workflow triggers. #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/codeql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: CodeQL

on:
pull_request:
push:
branches:
- '**'
workflow_dispatch:
Comment on lines 3 to 7
Copy link

@coderabbitai coderabbitai bot Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Critical: Verify PR scanning coverage after trigger changes.

By removing the pull_request event, you’ve disabled CodeQL scans on PRs, which prevents early security feedback for contributors. If you still need scanning during pull requests, re-add the trigger. For example:

on:
  push:
    branches:
      - '**'
  pull_request:
    branches:
      - '**'
  workflow_dispatch:

🏁 Script executed:

#!/bin/bash
# Display the first 20 lines of the CodeQL workflow to verify configured triggers
sed -n '1,20p' .github/workflows/codeql.yaml

Length of output: 302

Add pull_request trigger to .github/workflows/codeql.yaml

You’ve removed the pull_request event, which means CodeQL will only run on pushes and manual dispatches—PRs won’t be scanned automatically. To restore early security feedback on pull requests, update your workflow’s triggers:

 on:
   push:
     branches:
       - '**'
+  pull_request:
+    branches:
+      - '**'
   workflow_dispatch:

• File: .github/workflows/codeql.yaml (lines 2–6)
• Include the pull_request block to ensure scans run on PRs as well.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
on:
pull_request:
push:
branches:
- '**'
workflow_dispatch:
on:
push:
branches:
- '**'
pull_request:
branches:
- '**'
workflow_dispatch:


jobs:
Expand Down