[2.x] Extract back NavItem class for dropdowns #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
0ef6e95 to
2ba269e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1601 +/- ##
================================================================
Coverage 99.95% 99.95%
- Complexity 1775 1778 +3
================================================================
Files 183 184 +1
Lines 4801 4809 +8
================================================================
+ Hits 4799 4807 +8
Misses 2 2 ☔ View full report in Codecov by Sentry. |
This reverts commit b4928c5.
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
81e16fb to
737734d
Compare
Co-Authored-By: GPT 3.5 Turbo <openai-machine-user@hydephp.com>
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
02a2aac to
0132df1
Compare
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
89665b1 to
a888012
Compare
This makes more sense as a method on the NavGroupItem class.
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
1bfc6b6 to
4ca2b69
Compare
emmadesilva
force-pushed
the
extract-back-navitem-dropdown-class
branch
from
fd59578 to
e830cda
Compare
Since splitting out the class this is already null from the start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the dedicated class for grouped navigation items, but implemented better this time. This better separates concerns, and makes the data state of both classes clearer, and reduces the need for conditional returns and state dependent type logic. Targets #1568