[2.x] Expand abbreviated navigation item class names #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1625 +/- ##
================================================================
Coverage 99.87% 99.87%
Complexity 1778 1778
================================================================
Files 184 184
Lines 4808 4808
================================================================
Hits 4802 4802
Misses 6 6 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
expand-abbreviated-navigation-item-class-names
branch
from
9bcabd1 to
f2500f6
Compare
emmadesilva
force-pushed
the
expand-abbreviated-navigation-item-class-names
branch
from
f2500f6 to
b3cf010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the NavItem and NavItemGroup classes to not be abbreviated. Sure, the NavItem naming is very broadly understood and there is a balance between verboseness and conciseness, but these are the only two abbreviated classes in all of HydePHP and I think the consistency weights in most here.
Targets #1568