[2.x] Simplify navigation item group state handling to be deterministic #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to move away from depending so much on the keys
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1632 +/- ##
===================================================================
- Coverage 99.85% 99.85% -0.01%
- Complexity 1782 1783 +1
===================================================================
Files 185 185
Lines 4814 4812 -2
===================================================================
- Hits 4807 4805 -2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Tests are failing because of how the unit tests are set up. Deterministically discovering which group is active means that the groups actually need to be present in the kernel, just mocking the current page is not enough. See dc4a539 |
emmadesilva
force-pushed
the
simplify-navigation-item-group-state-handling
branch
from
d42416a to
7161f0b
Compare
This is temporary as I want to visualise how the data is passed here for the refactor
This reverts commit 3938201.
Apparently some tests use other pages, and I think that's fine for now
emmadesilva
force-pushed
the
simplify-navigation-item-group-state-handling
branch
from
8a2e460 to
2f8b7cc
Compare
emmadesilva
force-pushed
the
simplify-navigation-item-group-state-handling
branch
from
10b9797 to
5b51089
Compare
emmadesilva
force-pushed
the
simplify-navigation-item-group-state-handling
branch
from
5c9a917 to
d0ef005
Compare
Performance consideration is negligible (new is 0.038ms instead of 0.085ms) but it makes it more understandable and reduces the need of a complex loop
emmadesilva
force-pushed
the
simplify-navigation-item-group-state-handling
branch
from
24d7e2e to
c860213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #1568