[2.x] Create better fallbacks when not supplying a navigation item label #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1638 +/- ##
================================================================
Coverage 99.93% 99.93%
- Complexity 1779 1780 +1
================================================================
Files 184 184
Lines 4802 4807 +5
================================================================
+ Hits 4799 4804 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. |
emmadesilva
commented
Mar 24, 2024
packages/framework/src/Framework/Features/Navigation/NavigationItem.php
Outdated
Show resolved
Hide resolved
This reverts commit ea50e0f. See https://github.com/hydephp/develop/pull/1638/files#r1536861523 Revert "Extract helper method" This reverts commit 99ef0ed.
emmadesilva
deleted the
create-better-fallbacks-when-not-supplying-a-navigation-item-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #1568
Since null is not allowed, we needed to coalesce to an empty string. This makes no sense from a practical usability perspective: What's the point of a link in the menu that you can't click because there is no label to click? It makes more sense to fall back to the link to make it usable, and give a nudge to the developer that they may want to change it into something more visually pleasing.