Skip to content

Conversation

@emmadesilva
Copy link
Member

Removes the hyde.css file from HydeFront as all its styles has now been refactored to Tailwind in #2024. This also massively simplifies the complex build steps. HydeFront now only contains the compiled app.css file to serve through the CDN. And technically we may even consider changing this to load from the file in hydephp/hyde, depending on if step two in #2024 reduces the need for this package.

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 17, 2024
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b238280) to head (a12b565).
Report is 17 commits behind head on refactor-hydefront-styles-to-tailwind.

Additional details and impacted files
@@                            Coverage Diff                            @@
##             refactor-hydefront-styles-to-tailwind     #2037   +/-   ##
=========================================================================
  Coverage                                   100.00%   100.00%           
  Complexity                                    1906      1906           
=========================================================================
  Files                                          195       195           
  Lines                                         5080      5080           
=========================================================================
  Hits                                          5080      5080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva force-pushed the remove-the-hyde-css-file-from-hydefront branch from f1cf6dd to 2034b01 Compare November 17, 2024 15:14
@emmadesilva emmadesilva merged commit 3c42843 into refactor-hydefront-styles-to-tailwind Nov 17, 2024
@emmadesilva emmadesilva deleted the remove-the-hyde-css-file-from-hydefront branch November 17, 2024 15:18
@github-actions github-actions bot removed the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 17, 2024
@emmadesilva emmadesilva changed the title Remove the hyde.css file from HydeFront [2.x] Remove the hyde.css file from HydeFront Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants