[2.x] Upgrade monorepo to use Pest 3 and remove Psalm #2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
update-composer-dependencies
branch
3 times, most recently
from
834f9c0 to
839e43f
Compare
emmadesilva
force-pushed
the
update-composer-dependencies
branch
from
a67e826 to
584ce5c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
emmadesilva
force-pushed
the
update-composer-dependencies
branch
from
75e4b94 to
4d43410
Compare
emmadesilva
changed the title
emmadesilva
force-pushed
the
update-composer-dependencies
branch
4 times, most recently
from
cd690af to
94d0d4f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2270 +/- ##
==========================================
Coverage ? 100.00%
Complexity ? 2045
==========================================
Files ? 198
Lines ? 5274
Branches ? 0
==========================================
Hits ? 5274
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
I have spent too many hours on this, and given that we are upgrading to Pest 4 after anyways I don't want to waste more hours of my life fighting with PHPUnit which refuses to say what's actually wrong
emmadesilva
force-pushed
the
update-composer-dependencies
branch
2 times, most recently
from
4992e75 to
cc8e4a9
Compare
emmadesilva
force-pushed
the
update-composer-dependencies
branch
from
cc8e4a9 to
da32ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades from Pest 2 to Pest 3. And Psalm is currently more trouble than it's worth, and we can get type coverage from Pest. In the same PR as Psalm was blocking the install.