Skip to content

Conversation

@emmadesilva
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c041a71) to head (70774ca).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #2299   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2001      2001           
===========================================
  Files            197       197           
  Lines           5179      5179           
===========================================
  Hits            5179      5179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emmadesilva emmadesilva force-pushed the fix/Improve-handling-when-running-Vite-without-node-modules branch 2 times, most recently from 58a4146 to 102911b Compare September 27, 2025 17:06
@emmadesilva emmadesilva requested a review from Copilot September 27, 2025 17:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the Vite integration by adding proper validation and installation prompts for Node.js dependencies before attempting to start the Vite development server.

  • Added validation to check if node_modules and package.json exist before starting Vite
  • Implemented interactive prompts to automatically install Node dependencies when missing
  • Enhanced error handling with try-catch blocks around the Vite process startup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/realtime-compiler/src/Console/Commands/ServeCommand.php Adds node modules validation, installation prompts, and improved error handling for Vite startup
packages/framework/tests/Feature/Commands/ServeCommandTest.php Comprehensive test coverage for various node modules scenarios and installation flows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emmadesilva emmadesilva force-pushed the fix/Improve-handling-when-running-Vite-without-node-modules branch from 228df63 to 70774ca Compare September 27, 2025 17:49
@emmadesilva emmadesilva merged commit 73fb215 into master Sep 27, 2025
20 checks passed
@emmadesilva emmadesilva deleted the fix/Improve-handling-when-running-Vite-without-node-modules branch September 27, 2025 17:58
@emmadesilva emmadesilva changed the title Improve handling when running Vite without node modules [2.x] Improve handling when running Vite without node modules Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2 Beta Feedback] Serve command with Vite flag should fail if Node modules are not installed

2 participants