Fix realtime compiler loading assets from production URL#2418
Draft
emmadesilva wants to merge 1 commit intomasterfrom
Draft
Fix realtime compiler loading assets from production URL#2418emmadesilva wants to merge 1 commit intomasterfrom
emmadesilva wants to merge 1 commit intomasterfrom
Conversation
When the realtime compiler served pages with a configured site URL (e.g. hydephp.com), asset and media file references were generated as absolute URLs pointing to the production host, causing the browser to request files from production instead of the local server. Override the configured site URL to the current request's host:port when booting the application for page compilation. This ensures all generated asset links resolve against localhost (or the configured dev server) rather than production. Skip the override when save_preview is enabled to avoid baking the local URL into persisted output files. Closes #2327 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2003 2003
===========================================
Files 197 197
Lines 5135 5135
===========================================
Hits 5135 5135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes the realtime compiler generating absolute asset/media URLs pointing at the configured production hyde.url by overriding the site URL to the current request host during local page compilation (while avoiding persisted output when save_preview is enabled).
Changes:
- Override
config('hyde.url')toscheme://host[:port]for realtime-compiled responses. - Skip the override when
hyde.server.save_previewis enabled. - Add PHPUnit coverage for scheme/host fallback and the
save_previewguard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/realtime-compiler/src/Routing/Router.php | Overrides hyde.url during request handling so compiled pages reference the local server host instead of production. |
| packages/realtime-compiler/tests/RealtimeCompilerTest.php | Adds tests validating the override behavior (host, HTTPS, fallback, and save_preview opt-out). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+252
to
+254
| $this->mockCompilerRoute(''); | ||
| $_SERVER['HTTP_HOST'] = 'localhost:8080'; | ||
|
|
Comment on lines
+92
to
97
| $host = $_SERVER['HTTP_HOST'] ?? 'localhost'; | ||
|
|
||
| config(['hyde.url' => "$scheme://$host"]); | ||
| } | ||
|
|
||
| /** |
Comment on lines
+92
to
+93
| $host = $_SERVER['HTTP_HOST'] ?? 'localhost'; | ||
|
|
Comment on lines
+218
to
+262
| $_SERVER['HTTP_HOST'] = 'localhost:8080'; | ||
|
|
||
| config(['hyde.url' => 'https://hydephp.com']); | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('http://localhost:8080', config('hyde.url')); | ||
| } | ||
|
|
||
| public function testOverridesSiteUrlUsesHttpsSchemeForSecureRequests() | ||
| { | ||
| $this->mockCompilerRoute(''); | ||
| $_SERVER['HTTP_HOST'] = 'hyde.test'; | ||
| $_SERVER['HTTPS'] = 'on'; | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('https://hyde.test', config('hyde.url')); | ||
|
|
||
| unset($_SERVER['HTTPS']); | ||
| } | ||
|
|
||
| public function testOverridesSiteUrlFallsBackToLocalhostWhenHostIsMissing() | ||
| { | ||
| $this->mockCompilerRoute(''); | ||
| unset($_SERVER['HTTP_HOST']); | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('http://localhost', config('hyde.url')); | ||
| } | ||
|
|
||
| public function testDoesNotOverrideSiteUrlWhenSavePreviewIsEnabled() | ||
| { | ||
| $this->mockCompilerRoute(''); | ||
| $_SERVER['HTTP_HOST'] = 'localhost:8080'; | ||
|
|
||
| config([ | ||
| 'hyde.server.save_preview' => true, | ||
| 'hyde.url' => 'https://hydephp.com', | ||
| ]); | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('https://hydephp.com', config('hyde.url')); |
Comment on lines
+217
to
+247
| $this->mockCompilerRoute(''); | ||
| $_SERVER['HTTP_HOST'] = 'localhost:8080'; | ||
|
|
||
| config(['hyde.url' => 'https://hydephp.com']); | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('http://localhost:8080', config('hyde.url')); | ||
| } | ||
|
|
||
| public function testOverridesSiteUrlUsesHttpsSchemeForSecureRequests() | ||
| { | ||
| $this->mockCompilerRoute(''); | ||
| $_SERVER['HTTP_HOST'] = 'hyde.test'; | ||
| $_SERVER['HTTPS'] = 'on'; | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('https://hyde.test', config('hyde.url')); | ||
|
|
||
| unset($_SERVER['HTTPS']); | ||
| } | ||
|
|
||
| public function testOverridesSiteUrlFallsBackToLocalhostWhenHostIsMissing() | ||
| { | ||
| $this->mockCompilerRoute(''); | ||
| unset($_SERVER['HTTP_HOST']); | ||
|
|
||
| $this->invokeOverrideSiteUrl(); | ||
|
|
||
| $this->assertSame('http://localhost', config('hyde.url')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the realtime compiler served pages with a configured site URL (e.g. hydephp.com), asset and media file references were generated as absolute URLs pointing to the production host, causing the browser to request files from production instead of the local server.
Override the configured site URL to the current request's host:port when booting the application for page compilation. This ensures all generated asset links resolve against localhost (or the configured dev server) rather than production.
Skip the override when save_preview is enabled to avoid baking the local URL into persisted output files.
Closes #2327