feat(node): boundary language flag — --language / --clear-language - #53
Merged
Conversation
Syncs openapi.json (boundary `language` field, h2o T0.1) and regenerates the wire crate (node_data/wire_node_data gain `language: Option<Option<String>>`), then mirrors path_prefix → language across the hand-written layer for full CRUD parity with /v1: - cli.rs: `--language` on node add + set; `--clear-language` (conflicts_with). - staging: NodeSpec/NodeEdit/NodeUpdated + OpSummary carry language; add/update delta build via scalar_or_clear; boundary-only guards reject it on behavior/state/io (mirrored error text). - cmd/node.rs + diff.rs: human + JSON rendering of language. - 4 new tests: add sets language, state/io reject it, set + clear round-trip. cargo build + clippy -D warnings clean; 292 lib + 7 help tests pass. Wire regen is idempotent against the pinned 7.18.0 generator (verified: regen on main's own openapi produces zero drift, so CI wire-drift will pass). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…er test - The update "nothing to set" hint now lists --language among the field flags. - The scalar-render test asserts a non-null language renders in both human (language: go) and JSON output (was language: None, so the render path was unpinned). - Completeness: the lone-scalar and lone-clear parametrized tables now include language / clear_language. clippy -D warnings clean; 292 lib tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
languageCRUD support to the CLI, matching the h2o boundary-onlylanguagefield (T0.1) at 1:1 parity with the/v1delta API.Changes
openapi.jsonfrom app;scripts/regen-wire.shregenerated the wire crate. Onlynode_data.rs+wire_node_data.rschange (each gainslanguage: Option<Option<String>>) — no unrelated churn.--languageonnode addandnode set;--clear-language(conflicts_with = "language"), mirroring--path-prefix/--clear-path-prefix.languageonNodeSpec/NodeEdit/NodeUpdated+OpSummary; add/update delta build viascalar_or_clear; boundary-only guards reject--languageon behavior/state/io.--clear-languageround-trip.Gates
cargo build+cargo clippy --workspace --all-targets -- -D warningsclean; 292 lib + 7 help tests pass. Wire regen verified deterministic against the pinned 7.18.0 generator (regen on main's own openapi → zero drift), so thewire-driftCI gate will pass.Part of the multi-language import work (planning #202/#204). T0.5.
🤖 Generated with Claude Code