Conversation
Closed
severo
added a commit
that referenced
this pull request
Oct 29, 2025
Merged
severo
added a commit
that referenced
this pull request
Oct 29, 2025
* partially revert #303 and ignore eslint rule * cellPosition is memoized * remove dead code * the ref is provided by the context, thus triggers the effect * format * simplify the code, remove eslint warning * use scrollTo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated multiple parts of the code to fix new errors reported after upgrading react-hooks ESLint plugin, thanks to the excellent rule https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect.
Note that it removes useEffect hooks on one side, but we have to (or, the only solution I found is to) add other useEffect hooks to keep the reference to HTML elements in a state. So... not sure if the code is simpler overall, but I guess we respect the rules of React a bit more...