Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors side effects in two components to improve their reliability and fix potential issues with state management and ref access. The changes convert imperative code that runs conditionally after render into proper useEffect hooks with appropriate dependencies.
- Converted scroll logic in
HighTablefrom conditional imperative code to a properuseEffecthook - Replaced
scrollTomethod with directscrollTopassignment for better jsdom compatibility - Fixed
ColumnMenucontainer initialization logic to throw an error whencontainerRefis unexpectedly null
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/HighTable/HighTable.tsx | Refactored scroll-to-cell logic into useEffect hook and replaced scrollTo with direct scrollTop assignment |
| src/components/ColumnMenu/ColumnMenu.tsx | Fixed container initialization to throw error when containerRef is not set instead of silently failing |
##Copilot Suggestions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
severo
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #311
partially reverts #303